Skip to content

Add NonPreemptivePriorityScheduling new algorithm with unit tests #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 3, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.22%. Comparing base (c301fec) to head (c574498).

Files with missing lines Patch % Lines
...ms/scheduling/NonPreemptivePriorityScheduling.java 94.73% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5535      +/-   ##
============================================
+ Coverage     64.13%   64.22%   +0.08%     
- Complexity     4205     4217      +12     
============================================
  Files           587      588       +1     
  Lines         16388    16426      +38     
  Branches       3163     3170       +7     
============================================
+ Hits          10511    10549      +38     
  Misses         5448     5448              
  Partials        429      429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan changed the title Add NonPreemptivePriorityScheduling new algorithm with unit tests Add NonPreemptivePriorityScheduling new algorithm with unit tests Oct 3, 2024
@Hardvan Hardvan marked this pull request as ready for review October 3, 2024 05:37
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 6, 2024

I have added the startTime attribute to the scheduling code and modified the Junit tests to reflect the same.

@Hardvan Hardvan requested a review from siriak October 6, 2024 07:56
…ng.java' into non_preemptive_priority_scheduling.java
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 8, 2024

I added another variable called arrivalTime to keep track of this.

@Hardvan Hardvan requested a review from siriak October 8, 2024 09:56
@Hardvan Hardvan requested a review from siriak October 9, 2024 12:52
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 9, 2024

I have added a waitingQueue variable to address the above change.

@siriak siriak merged commit 213fd5a into TheAlgorithms:master Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants