Skip to content

Enhance readability, add comments & function docs to SkylineProblem.java #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 7, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 3, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (f34fe4d) to head (0f6001a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5534      +/-   ##
============================================
+ Coverage     54.56%   54.96%   +0.40%     
- Complexity     3413     3426      +13     
============================================
  Files           535      535              
  Lines         15383    15362      -21     
  Branches       2935     2932       -3     
============================================
+ Hits           8393     8443      +50     
+ Misses         6637     6564      -73     
- Partials        353      355       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 3, 2024 04:58
@Hardvan Hardvan requested a review from siriak October 5, 2024 14:12
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 5, 2024

I have removed the print and main methods along with the addition of Junit tests.

siriak
siriak previously approved these changes Oct 7, 2024
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 7, 2024 12:16
@siriak siriak disabled auto-merge October 7, 2024 12:23
@siriak siriak merged commit 2592a08 into TheAlgorithms:master Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants