Skip to content

Add function documentation, enhance comments in TowerOfHanoi.java #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 13, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 3, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (ee6cd64) to head (903c69a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5533      +/-   ##
============================================
+ Coverage     54.73%   54.80%   +0.06%     
- Complexity     3453     3456       +3     
============================================
  Files           538      538              
  Lines         15583    15577       -6     
  Branches       2961     2961              
============================================
+ Hits           8530     8537       +7     
+ Misses         6695     6683      -12     
+ Partials        358      357       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 3, 2024 04:52
@Hardvan Hardvan requested a review from siriak October 5, 2024 14:12
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 5, 2024

I have replaced the main method with JUnit tests.

@Hardvan Hardvan requested a review from alxkm October 6, 2024 12:38
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 6, 2024

The suggested changes for the class & function documentation improvement have been implemented.

siriak
siriak previously approved these changes Oct 13, 2024
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
Copy link
Member

siriak commented Oct 13, 2024

@alxkm please review

alxkm
alxkm previously approved these changes Oct 13, 2024
@github-actions github-actions bot dismissed stale reviews from alxkm and siriak via e557086 October 13, 2024 09:16
@alxkm alxkm enabled auto-merge (squash) October 13, 2024 09:17
@Hardvan Hardvan requested review from alxkm and siriak October 13, 2024 09:25
@siriak siriak disabled auto-merge October 13, 2024 09:30
@siriak siriak merged commit 596c614 into TheAlgorithms:master Oct 13, 2024
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 13, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants