-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Improve TrieImp.java
comments, add unit tests and enhance readability
#5526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5526 +/- ##
============================================
+ Coverage 52.95% 53.32% +0.36%
- Complexity 3309 3322 +13
============================================
Files 529 529
Lines 15343 15306 -37
Branches 2925 2919 -6
============================================
+ Hits 8125 8162 +37
+ Misses 6882 6809 -73
+ Partials 336 335 -1 ☔ View full report in Codecov by Sentry. |
TrieImp.java
comments & enhance readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pleaser replace main with JUnit tests and remove trivial comments that just duplicate code from function bodies
…to trie_improvement
…to trie_improvement
I have removed duplicate comments, main method, and added Junit tests for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
TrieImp.java
comments & enhance readabilityTrieImp.java
comments, add unit tests and enhance readability
Thanks! |
clang-format -i --style=file path/to/your/file.java