Skip to content

Improve TrieImp.java comments, add unit tests and enhance readability #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 5, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 2, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.32%. Comparing base (be8df21) to head (b77b258).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5526      +/-   ##
============================================
+ Coverage     52.95%   53.32%   +0.36%     
- Complexity     3309     3322      +13     
============================================
  Files           529      529              
  Lines         15343    15306      -37     
  Branches       2925     2919       -6     
============================================
+ Hits           8125     8162      +37     
+ Misses         6882     6809      -73     
+ Partials        336      335       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 2, 2024 14:48
@Hardvan Hardvan changed the title Improve TrieImp.java comments & enhance readability Improve TrieImp.java comments & enhance readability Oct 3, 2024
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleaser replace main with JUnit tests and remove trivial comments that just duplicate code from function bodies

@Hardvan Hardvan requested a review from siriak October 4, 2024 14:44
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 4, 2024

I have removed duplicate comments, main method, and added Junit tests for the Trie algorithm.

siriak
siriak previously approved these changes Oct 5, 2024
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 5, 2024 08:40
@siriak siriak disabled auto-merge October 5, 2024 09:47
@siriak siriak merged commit ce34595 into TheAlgorithms:master Oct 5, 2024
@Hardvan Hardvan changed the title Improve TrieImp.java comments & enhance readability Improve TrieImp.java comments, add unit tests and enhance readability Oct 5, 2024
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants