-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Created DiffieHellman.java and MonoAlphabetic.java #5508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5508 +/- ##
============================================
- Coverage 66.98% 66.97% -0.01%
- Complexity 4523 4530 +7
============================================
Files 613 615 +2
Lines 16990 17019 +29
Branches 3282 3286 +4
============================================
+ Hits 11380 11398 +18
- Misses 5160 5166 +6
- Partials 450 455 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the main
methods and add proper junit tests. Prefer ParameterizedTest
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vil02,
I have made the necessary changes according to your suggestions.
Thank you for your valuable feedback!
@vil02 please review |
Hi @vil02, kindly review the changed code. |
Hello @vil02 @siriak @alxkm @BamaCharanChhandogi @yanglbme |
Description
This PR implements the Diffie-Hellman Key Exchange and MonoAlphabetic Cipher algorithms.
Key Changes:
Diffie-Hellman Key Exchange:
DiffieHellman.java
under theciphers
directory.MonoAlphabetic Cipher:
MonoAlphabetic.java
under theciphers
directory.Both algorithms are utility classes, with private constructors to prevent instantiation and static methods to handle their respective functionalities.
clang-format -i --style=file path/to/your/file.java