-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Gale-Shapley Algorithm and Tests #5494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests and Directory.md update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5494 +/- ##
============================================
+ Coverage 52.29% 52.31% +0.01%
- Complexity 3257 3260 +3
============================================
Files 525 526 +1
Lines 15185 15205 +20
Branches 2887 2892 +5
============================================
+ Hits 7941 7954 +13
- Misses 6920 6924 +4
- Partials 324 327 +3 ☔ View full report in Codecov by Sentry. |
siriak
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This pull request adds the implementation of the Gale-Shapley algorithm (Stable Marriage Problem) to the greedyalgorithms package. The algorithm allows for finding stable matches between two sets (men and women) based on their preferences. In addition to the algorithm, unit tests have been added to ensure correctness, and the DIRECTORY.md file has been updated to reflect this new addition.
Changes:
New Algorithm: Gale-Shapley algorithm for stable matching.
Unit Tests: JUnit tests added to validate the correctness of the Gale-Shapley algorithm with various scenarios, including multiple preferences, single pair matching, and equal preferences.
Directory Update: Updated DIRECTORY.md to include the new Gale-Shapley algorithm under the greedyalgorithms section.
Checklist:
clang-format -i --style=file path/to/your/file.java