Skip to content

Gale-Shapley Algorithm and Tests #5494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Gale-Shapley Algorithm and Tests #5494

merged 9 commits into from
Oct 2, 2024

Conversation

BKarthik7
Copy link
Contributor

Overview:
This pull request adds the implementation of the Gale-Shapley algorithm (Stable Marriage Problem) to the greedyalgorithms package. The algorithm allows for finding stable matches between two sets (men and women) based on their preferences. In addition to the algorithm, unit tests have been added to ensure correctness, and the DIRECTORY.md file has been updated to reflect this new addition.

Changes:
New Algorithm: Gale-Shapley algorithm for stable matching.
Unit Tests: JUnit tests added to validate the correctness of the Gale-Shapley algorithm with various scenarios, including multiple preferences, single pair matching, and equal preferences.
Directory Update: Updated DIRECTORY.md to include the new Gale-Shapley algorithm under the greedyalgorithms section.
Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.31%. Comparing base (dab8ff3) to head (c9f7944).

Files with missing lines Patch % Lines
...om/thealgorithms/greedyalgorithms/GaleShapley.java 65.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5494      +/-   ##
============================================
+ Coverage     52.29%   52.31%   +0.01%     
- Complexity     3257     3260       +3     
============================================
  Files           525      526       +1     
  Lines         15185    15205      +20     
  Branches       2887     2892       +5     
============================================
+ Hits           7941     7954      +13     
- Misses         6920     6924       +4     
- Partials        324      327       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BKarthik7 BKarthik7 marked this pull request as draft October 1, 2024 10:58
@BKarthik7 BKarthik7 marked this pull request as ready for review October 1, 2024 11:30
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 2, 2024 13:48
@siriak siriak merged commit e6f597a into TheAlgorithms:master Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants