Skip to content

Update CheckVowels.java #5492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

utkarsh2004git
Copy link

@utkarsh2004git utkarsh2004git commented Oct 1, 2024

Optimized the code by extending the Set elements

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Optimized the code by extending the Set elements
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.31%. Comparing base (7f60d57) to head (d7e320c).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5492      +/-   ##
============================================
+ Coverage     52.28%   52.31%   +0.02%     
- Complexity     3256     3257       +1     
============================================
  Files           525      525              
  Lines         15185    15186       +1     
  Branches       2887     2887              
============================================
+ Hits           7940     7944       +4     
+ Misses         6920     6919       -1     
+ Partials        325      323       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utkarsh2004git
Copy link
Author

Optimized the code for src/main/java/com/thealgorithms/strings/CheckVowels.java

@siriak
Copy link
Member

siriak commented Oct 2, 2024

The original code is fine, not worth optimizing in this way in my opinion, but thanks for the suggestion anyway!

@siriak siriak closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants