Skip to content

Improve comments in Mcoloring.java #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 2, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Sep 30, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.30%. Comparing base (0bd86b3) to head (2190d6d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5484   +/-   ##
=========================================
  Coverage     52.29%   52.30%           
+ Complexity     3257     3256    -1     
=========================================
  Files           525      525           
  Lines         15185    15185           
  Branches       2887     2887           
=========================================
+ Hits           7941     7942    +1     
+ Misses         6920     6919    -1     
  Partials        324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review September 30, 2024 17:18
@Hardvan Hardvan requested a review from siriak October 2, 2024 11:05
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit dab8ff3 into TheAlgorithms:master Oct 2, 2024
6 checks passed
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 2, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants