Skip to content

fix: handle Null Dereference in NthUglyNumber #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 24, 2024

Continuation of #5456.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.30%. Comparing base (1460eb7) to head (22cd14b).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5469   +/-   ##
=========================================
  Coverage     52.30%   52.30%           
  Complexity     3256     3256           
=========================================
  Files           525      525           
  Lines         15183    15184    +1     
  Branches       2887     2887           
=========================================
+ Hits           7941     7942    +1     
  Misses         6919     6919           
  Partials        323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 force-pushed the NULLPTR_DEREFERENCE_in_NthUglyNumber branch from e907c33 to f00cc58 Compare September 24, 2024 15:53
@vil02 vil02 force-pushed the NULLPTR_DEREFERENCE_in_NthUglyNumber branch from f00cc58 to 22cd14b Compare September 24, 2024 15:57
@vil02 vil02 marked this pull request as ready for review September 24, 2024 15:59
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@BamaCharanChhandogi BamaCharanChhandogi merged commit 27343e7 into TheAlgorithms:master Sep 24, 2024
6 checks passed
@vil02 vil02 deleted the NULLPTR_DEREFERENCE_in_NthUglyNumber branch September 24, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants