-
Notifications
You must be signed in to change notification settings - Fork 19.9k
refactor: DuplicateBrackets
#5424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: DuplicateBrackets
#5424
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5424 +/- ##
============================================
+ Coverage 50.65% 50.72% +0.06%
- Complexity 3131 3136 +5
============================================
Files 523 523
Lines 15125 15128 +3
Branches 2879 2880 +1
============================================
+ Hits 7662 7674 +12
+ Misses 7141 7129 -12
- Partials 322 325 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to the DuplicateBrackets class. Your changes have improved the code's readability and robustness. To further enhance the functionality and versatility of this class, we suggest the following updates:
@BamaCharanChhandogi, thank you. But which updates you would suggest? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Class cleanup.
Readability improvements.
Added tests.
clang-format -i --style=file path/to/your/file.java