Skip to content

refactor: DuplicateBrackets #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2024
Merged

refactor: DuplicateBrackets #5424

merged 4 commits into from
Aug 29, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 27, 2024

Class cleanup.
Readability improvements.
Added tests.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.72%. Comparing base (e2aaefe) to head (e73330d).

Files with missing lines Patch % Lines
...va/com/thealgorithms/stacks/DuplicateBrackets.java 72.72% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5424      +/-   ##
============================================
+ Coverage     50.65%   50.72%   +0.06%     
- Complexity     3131     3136       +5     
============================================
  Files           523      523              
  Lines         15125    15128       +3     
  Branches       2879     2880       +1     
============================================
+ Hits           7662     7674      +12     
+ Misses         7141     7129      -12     
- Partials        322      325       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to the DuplicateBrackets class. Your changes have improved the code's readability and robustness. To further enhance the functionality and versatility of this class, we suggest the following updates:

@alxkm
Copy link
Contributor Author

alxkm commented Aug 28, 2024

@BamaCharanChhandogi, thank you. But which updates you would suggest?

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BamaCharanChhandogi BamaCharanChhandogi merged commit c57e02d into TheAlgorithms:master Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants