Skip to content

Rabin Karp Algorithm for searching the given string in string #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Lohit-pro
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 49.23%. Comparing base (633b9d4) to head (050cd02).
Report is 2 commits behind head on master.

Files Patch % Lines
...ithms/strings/PatternSearchUsingRabinKarpAlgo.java 0.00% 35 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5414      +/-   ##
============================================
- Coverage     49.36%   49.23%   -0.13%     
  Complexity     3067     3067              
============================================
  Files           524      525       +1     
  Lines         15204    15239      +35     
  Branches       2890     2900      +10     
============================================
- Hits           7505     7503       -2     
- Misses         7388     7424      +36     
- Partials        311      312       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lohit-pro
Copy link
Author

Hey @BurkHufnagel Sorry to bother you, but whats the error? Why isn't it getting built? I have checked the details but didnt get where the issue is... :(

@alxkm
Copy link
Contributor

alxkm commented Aug 27, 2024

I am not mentioned person by @Lohit-pro, but there are few issues:

Error: PatternSearchUsingRabinKarpAlgo.java:2:17: Using the '.' form of import should be avoided - java.util.. [AvoidStarImport]

Error: PatternSearchUsingRabinKarpAlgo.java:11:1: Utility classes should not have a public or default constructor. [HideUtilityClassConstructor]

More logs:
https://github.com/TheAlgorithms/Java/actions/runs/10586074339/job/29334079556?pr=5414

And looks like the this algorithm already exists in "com.thealgorithms.others.RabinKarp"?

@Lohit-pro Lohit-pro closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants