Skip to content

refactor: ReverseString, test improvements #5406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/main/java/com/thealgorithms/strings/ReverseString.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ public final class ReverseString {
private ReverseString() {
}

public static void main(String[] args) {
assert reverse("abc123").equals("321cba");
assert reverse2("abc123").equals("321cba");
}

/**
* easiest way to reverses the string str and returns it
*
Expand Down
29 changes: 7 additions & 22 deletions src/test/java/com/thealgorithms/strings/ReverseStringTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,15 @@

import static org.junit.jupiter.api.Assertions.assertEquals;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;

public class ReverseStringTest {

@Test
public void testReverseString() {
String input1 = "Hello World";
String input2 = "helloworld";
String input3 = "123456789";
String input4 = "";

String expectedOutput1 = "dlroW olleH";
String expectedOutput2 = "dlrowolleh";
String expectedOutput3 = "987654321";
String expectedOutput4 = "";

assertEquals(ReverseString.reverse(input1), expectedOutput1);
assertEquals(ReverseString.reverse(input2), expectedOutput2);
assertEquals(ReverseString.reverse(input3), expectedOutput3);
assertEquals(ReverseString.reverse(input4), expectedOutput4);

assertEquals(ReverseString.reverse2(input1), expectedOutput1);
assertEquals(ReverseString.reverse2(input2), expectedOutput2);
assertEquals(ReverseString.reverse2(input3), expectedOutput3);
assertEquals(ReverseString.reverse2(input4), expectedOutput4);
@ParameterizedTest
@CsvSource({"'Hello World', 'dlroW olleH'", "'helloworld', 'dlrowolleh'", "'123456789', '987654321'", "'', ''", "'A', 'A'", "'ab', 'ba'", "' leading and trailing spaces ', ' secaps gniliart dna gnidael '", "'!@#$%^&*()', ')(*&^%$#@!'", "'MixOf123AndText!', '!txeTdnA321fOxiM'"})
public void testReverseString(String input, String expectedOutput) {
assertEquals(expectedOutput, ReverseString.reverse(input));
assertEquals(expectedOutput, ReverseString.reverse2(input));
}
}