Skip to content

refactor: BalancedBrackets #5391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 25, 2024
Merged

refactor: BalancedBrackets #5391

merged 6 commits into from
Aug 25, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 25, 2024

Some improvements.
Added tests.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (580aa0c) to head (c19355a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5391      +/-   ##
============================================
+ Coverage     47.50%   47.60%   +0.10%     
- Complexity     2934     2944      +10     
============================================
  Files           524      524              
  Lines         15316    15312       -4     
  Branches       2907     2906       -1     
============================================
+ Hits           7276     7290      +14     
+ Misses         7739     7720      -19     
- Partials        301      302       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak
Copy link
Member

siriak commented Aug 25, 2024

Could you make the tests parameterized? To avoid having 1 test that checks everything with separate assertions

@siriak siriak merged commit 7e9cdad into TheAlgorithms:master Aug 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants