Optimized LongestPalindromicSubstring.java (Reduced Time Complexity ) #5379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimized Longest Polindromic Substring from avg run time of 532ms to 13ms
Narasimha-png
requested review from
yanglbme,
vil02,
BamaCharanChhandogi and
alxkm
as code owners
|
Reduced Time Complexity from avg run time 434ms to 13 ms |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5379 +/- ##
============================================
+ Coverage 46.90% 46.92% +0.02%
- Complexity 2903 2904 +1
============================================
Files 525 525
Lines 15363 15362 -1
Branches 2908 2905 -3
============================================
+ Hits 7206 7209 +3
+ Misses 7855 7853 -2
+ Partials 302 300 -2 ☔ View full report in Codecov by Sentry. |
BamaCharanChhandogi
requested changes
Aug 25, 2024
| for (int i = 0; i < n / 2; ++i) { | ||
| if (s.charAt(lo + i) != s.charAt(hi - i)) { | ||
| return false; | ||
| public void f(String s, int l, int r) { |
There was a problem hiding this comment.
Suggested change
| public void f(String s, int l, int r) { | |
| private void expandAroundCenter(String s, int l, int r) { |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
|
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized Longest Polindromic Substring from avg run time of 532ms to 13ms
clang-format -i --style=file path/to/your/file.java