Skip to content

refactor: PasswordGen #5373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2024
Merged

refactor: PasswordGen #5373

merged 2 commits into from
Aug 24, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 23, 2024

Refactor PasswordGen.
Adding tests.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.80%. Comparing base (4e72056) to head (18f6018).

Files Patch % Lines
...ain/java/com/thealgorithms/others/PasswordGen.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5373      +/-   ##
============================================
- Coverage     46.82%   46.80%   -0.02%     
- Complexity     2898     2900       +2     
============================================
  Files           525      525              
  Lines         15376    15373       -3     
  Branches       2910     2910              
============================================
- Hits           7200     7196       -4     
  Misses         7877     7877              
- Partials        299      300       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak merged commit 75355e8 into TheAlgorithms:master Aug 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants