Skip to content

refactor: cleanup AhoCorasick #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2024
Merged

refactor: cleanup AhoCorasick #5358

merged 4 commits into from
Aug 22, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 21, 2024

Change ArrayList to List, which provides more flexibility.
Removing redundant type in generics.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.86%. Comparing base (8a89b42) to head (01cb54a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5358      +/-   ##
============================================
- Coverage     45.88%   45.86%   -0.02%     
+ Complexity     2857     2856       -1     
============================================
  Files           525      525              
  Lines         15420    15418       -2     
  Branches       2917     2917              
============================================
- Hits           7076     7072       -4     
- Misses         8048     8049       +1     
- Partials        296      297       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak merged commit 622a3bf into TheAlgorithms:master Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants