Skip to content

refactor: CircularQueue #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

refactor: CircularQueue #5354

merged 2 commits into from
Aug 21, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 20, 2024

Make CircularQueue generic.
Readability improvements.
Added tests.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.60%. Comparing base (f5c0314) to head (63c0312).

Files Patch % Lines
...lgorithms/datastructures/queues/CircularQueue.java 65.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5354      +/-   ##
============================================
+ Coverage     44.38%   44.60%   +0.22%     
- Complexity     2752     2765      +13     
============================================
  Files           522      522              
  Lines         15419    15413       -6     
  Branches       2942     2939       -3     
============================================
+ Hits           6843     6875      +32     
+ Misses         8282     8242      -40     
- Partials        294      296       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak merged commit e756a7d into TheAlgorithms:master Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants