-
Notifications
You must be signed in to change notification settings - Fork 19.9k
refactor: BinaryToOctal
#5338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: BinaryToOctal
#5338
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5338 +/- ##
============================================
+ Coverage 43.05% 43.07% +0.02%
- Complexity 2669 2673 +4
============================================
Files 522 522
Lines 15472 15469 -3
Branches 2952 2953 +1
============================================
+ Hits 6661 6663 +2
+ Misses 8526 8521 -5
Partials 285 285 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the updated code looks great, but I suggest adding input validation to ensure the input is a valid binary number. Also, consider enhancing the test cases to cover potential edge cases like invalid inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
Improving the code to make it more readable.
Adding additional tests to this algorithm.
clang-format -i --style=file path/to/your/file.java