Skip to content

refactor: BinaryToOctal #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2024
Merged

refactor: BinaryToOctal #5338

merged 5 commits into from
Aug 17, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 17, 2024

Improving the code to make it more readable.
Adding additional tests to this algorithm.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.07%. Comparing base (25b6aeb) to head (cd01525).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5338      +/-   ##
============================================
+ Coverage     43.05%   43.07%   +0.02%     
- Complexity     2669     2673       +4     
============================================
  Files           522      522              
  Lines         15472    15469       -3     
  Branches       2952     2953       +1     
============================================
+ Hits           6661     6663       +2     
+ Misses         8526     8521       -5     
  Partials        285      285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the updated code looks great, but I suggest adding input validation to ensure the input is a valid binary number. Also, consider enhancing the test cases to cover potential edge cases like invalid inputs.

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@BamaCharanChhandogi BamaCharanChhandogi enabled auto-merge (squash) August 17, 2024 19:04
@BamaCharanChhandogi BamaCharanChhandogi merged commit e8985b3 into TheAlgorithms:master Aug 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants