Skip to content

refactor: DecimalToHexadecimal #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2024
Merged

refactor: DecimalToHexadecimal #5337

merged 3 commits into from
Aug 17, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 16, 2024

Rename the previous file.
Improving the code to make it more readable.
Adding additional tests to this algorithm.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.04%. Comparing base (d80fd0c) to head (ced0f5b).

Files Patch % Lines
...healgorithms/conversions/DecimalToHexadecimal.java 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5337      +/-   ##
============================================
+ Coverage     43.03%   43.04%   +0.01%     
- Complexity     2666     2670       +4     
============================================
  Files           522      522              
  Lines         15474    15472       -2     
  Branches       2950     2952       +2     
============================================
+ Hits           6659     6660       +1     
+ Misses         8532     8527       -5     
- Partials        283      285       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alxkm alxkm requested a review from siriak August 17, 2024 15:01
@siriak siriak merged commit 25b6aeb into TheAlgorithms:master Aug 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants