Skip to content

refactor: BinaryToDecimal #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024
Merged

refactor: BinaryToDecimal #5330

merged 2 commits into from
Aug 16, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 15, 2024

Refactoring BinaryToDecimal.
Adding tests for incorrect cases.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.68%. Comparing base (c20375a) to head (4e171c6).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5330      +/-   ##
============================================
+ Coverage     42.67%   42.68%   +0.01%     
  Complexity     2646     2646              
============================================
  Files           522      522              
  Lines         15488    15485       -3     
  Branches       2950     2951       +1     
============================================
+ Hits           6609     6610       +1     
+ Misses         8596     8591       -5     
- Partials        283      284       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak merged commit e32cab3 into TheAlgorithms:master Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants