Skip to content

refactor: cleanup CycleSort #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024
Merged

refactor: cleanup CycleSort #5321

merged 3 commits into from
Aug 15, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 13, 2024

CycleSort cleanup
Code readability improvements

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@c4e0adb). Learn more about missing BASE report.

Files Patch % Lines
...c/main/java/com/thealgorithms/sorts/CycleSort.java 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5321   +/-   ##
=========================================
  Coverage          ?   42.39%           
  Complexity        ?     2632           
=========================================
  Files             ?      522           
  Lines             ?    15524           
  Branches          ?     2958           
=========================================
  Hits              ?     6582           
  Misses            ?     8648           
  Partials          ?      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak merged commit 777de1d into TheAlgorithms:master Aug 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants