Skip to content

refactor: IntrospectiveSort #5316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2024
Merged

refactor: IntrospectiveSort #5316

merged 2 commits into from
Aug 11, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 11, 2024

Improving code readability, simplify in some places
Adding general sorting test as it provides better coverage
Adding Java docs with description of methods

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 13 lines in your changes missing coverage. Please review.

Project coverage is 42.29%. Comparing base (66bfaff) to head (a5be829).

Files Patch % Lines
...ava/com/thealgorithms/sorts/IntrospectiveSort.java 58.06% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5316      +/-   ##
============================================
+ Coverage     42.18%   42.29%   +0.10%     
- Complexity     2621     2627       +6     
============================================
  Files           522      522              
  Lines         15537    15540       +3     
  Branches       2964     2965       +1     
============================================
+ Hits           6555     6572      +17     
+ Misses         8685     8671      -14     
  Partials        297      297              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alxkm alxkm changed the title refactor: IntrospectiveSort, adding general sort test refactor: IntrospectiveSort Aug 11, 2024
@siriak siriak merged commit 2837585 into TheAlgorithms:master Aug 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants