Skip to content

Update checkstyle.xml #5311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bayramtturgutt
Copy link
Contributor

minor update

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.83%. Comparing base (6e23e19) to head (f7a00d6).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5311      +/-   ##
============================================
+ Coverage     41.81%   41.83%   +0.01%     
- Complexity     2588     2589       +1     
============================================
  Files           521      521              
  Lines         15505    15505              
  Branches       2963     2963              
============================================
+ Hits           6483     6486       +3     
+ Misses         8726     8725       -1     
+ Partials        296      294       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bayramtturgutt bayramtturgutt requested a review from alxkm as a code owner August 8, 2024 08:29
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the point of that change. The old version is more readable: the line is shorter and it is easier to read what the default is set to be. Moreover, the old version has a consistent formatting (cf. line 54)

@bayramtturgutt
Copy link
Contributor Author

I do not see the point of that change. The old version is more readable: the line is shorter and it is easier to read what the default is set to be. Moreover, the old version has a consistent formatting (cf. line 54)

You're right, I'm closing the PR. Thanks for your feedback! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants