Skip to content

refactor: cleanup ShellSort #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024
Merged

refactor: cleanup ShellSort #5302

merged 2 commits into from
Jul 26, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 25, 2024

Improving ShellSort code readability
Refactor the code by moving parts of it into well-named methods to improve readability and maintainability.
Adopt a more general testing approach to ensure better test coverage.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.47%. Comparing base (ebed8b3) to head (0d17676).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5302      +/-   ##
============================================
+ Coverage     41.41%   41.47%   +0.05%     
- Complexity     2551     2554       +3     
============================================
  Files           520      520              
  Lines         15447    15447              
  Branches       2950     2947       -3     
============================================
+ Hits           6398     6406       +8     
+ Misses         8754     8746       -8     
  Partials        295      295              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 5113101 into TheAlgorithms:master Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants