Skip to content

refactor: cleanup PigeonholeSort #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2024
Merged

refactor: cleanup PigeonholeSort #5298

merged 6 commits into from
Jul 25, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 21, 2024

This PR adds missed test.

Improve code structure, this should add more readability.

Replaced ArrayList<Integer>[] pigeonHole = new ArrayList[numOfPigeonholes]; with List<List<Integer>> pigeonHoles = new ArrayList<>(maxElement + 1);.
Because such constructions in Java is generally not considered good practice.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.42%. Comparing base (76a450f) to head (7d3fc42).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5298      +/-   ##
============================================
+ Coverage     41.24%   41.42%   +0.18%     
- Complexity     2539     2552      +13     
============================================
  Files           520      520              
  Lines         15449    15447       -2     
  Branches       2953     2950       -3     
============================================
+ Hits           6372     6399      +27     
+ Misses         8782     8754      -28     
+ Partials        295      294       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alxkm alxkm requested a review from vil02 July 25, 2024 07:58
@vil02 vil02 merged commit ebed8b3 into TheAlgorithms:master Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants