Skip to content

refactor: cleanup RadixSort #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 19, 2024
Merged

refactor: cleanup RadixSort #5280

merged 17 commits into from
Jul 19, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 9, 2024

Cleanup RadixSort

Adding test

Update DIRECTORY.md

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@f1e2606). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5280   +/-   ##
=========================================
  Coverage          ?   40.88%           
  Complexity        ?     2520           
=========================================
  Files             ?      519           
  Lines             ?    15452           
  Branches          ?     2945           
=========================================
  Hits              ?     6318           
  Misses            ?     8840           
  Partials          ?      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alxkm alxkm requested a review from vil02 July 15, 2024 18:24
@alxkm
Copy link
Contributor Author

alxkm commented Jul 19, 2024

Hello @vil02, all issues for this PR already fixed (also including negative numbers logic remove), could you please review this PR. Thanks.

@alxkm alxkm requested a review from vil02 July 19, 2024 16:10
@vil02 vil02 merged commit 9403214 into TheAlgorithms:master Jul 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants