Skip to content

making code more clean and readable #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

abdala-elgendy
Copy link
Contributor

@abdala-elgendy abdala-elgendy commented Jun 24, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.82%. Comparing base (a5b4c61) to head (25c8244).

Files Patch % Lines
...algorithms/datastructures/heaps/FibonacciHeap.java 25.00% 3 Missing ⚠️
...om/thealgorithms/datastructures/heaps/MaxHeap.java 0.00% 1 Missing ⚠️
...om/thealgorithms/datastructures/heaps/MinHeap.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5251   +/-   ##
=========================================
  Coverage     39.82%   39.82%           
  Complexity     2436     2436           
=========================================
  Files           517      517           
  Lines         15476    15476           
  Branches       2958     2958           
=========================================
  Hits           6163     6163           
  Misses         9022     9022           
  Partials        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yanglbme yanglbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@yanglbme yanglbme merged commit 7b17ead into TheAlgorithms:master Jun 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants