-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Improving BitonicSort #5244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving BitonicSort #5244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few more remarks, which I will share tomorrow.
There are issues with the build, not related to any recent code changes. The problem seems to be with the Codecov tool. |
Codecov behaves strange for few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Here are some small remarks to make it perfect.
The same for codecov. |
It seems to be related to codecov/codecov-action#1487. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5244 +/- ##
=========================================
Coverage ? 39.73%
Complexity ? 2435
=========================================
Files ? 517
Lines ? 15515
Branches ? 2958
=========================================
Hits ? 6165
Misses ? 9060
Partials ? 290 ☔ View full report in Codecov by Sentry. |
I cannot merge it now, because the upload to codecov fails. I will rerun the build in a while, so maybe it will pass. |
The previous sorting algorithm only worked with arrays whose sizes were powers of two. This issue has been fixed.
Additionally, the code has been refactored to follow a common approach, and tests for the sort function have been added.
clang-format -i --style=file path/to/your/file.java