Skip to content

refactor: redesign StringMatchFiniteAutomata #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

samuelfac
Copy link
Contributor

Related to #5164

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Samuel Facchinello added 2 commits June 12, 2024 15:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.46%. Comparing base (cdb3aff) to head (43227e8).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5222      +/-   ##
============================================
+ Coverage     39.22%   39.46%   +0.23%     
- Complexity     2401     2416      +15     
============================================
  Files           517      517              
  Lines         15522    15522              
  Branches       2958     2959       +1     
============================================
+ Hits           6089     6126      +37     
+ Misses         9140     9105      -35     
+ Partials        293      291       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Samuel Facchinello added 2 commits June 12, 2024 15:18
@samuelfac samuelfac marked this pull request as ready for review June 12, 2024 13:25
@vil02
Copy link
Member

vil02 commented Jun 12, 2024

Let's focus on #5221 first.

Copy link
Contributor Author

@samuelfac samuelfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed main

@samuelfac samuelfac requested a review from vil02 June 13, 2024 17:48
@samuelfac samuelfac requested a review from vil02 June 14, 2024 15:37
@vil02 vil02 changed the title Refactor: redesign StringMatchFiniteAutomata refactor: redesign StringMatchFiniteAutomata Jun 17, 2024
@vil02 vil02 enabled auto-merge (squash) June 17, 2024 20:54
@vil02 vil02 merged commit 9973b8e into TheAlgorithms:master Jun 17, 2024
4 checks passed
@samuelfac samuelfac deleted the cleanup_StringMatchFiniteAutomata branch June 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants