-
Notifications
You must be signed in to change notification settings - Fork 19.9k
refactor: redesign StringMatchFiniteAutomata
#5222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vil02
merged 17 commits into
TheAlgorithms:master
from
samuelfac:cleanup_StringMatchFiniteAutomata
Jun 17, 2024
Merged
refactor: redesign StringMatchFiniteAutomata
#5222
vil02
merged 17 commits into
TheAlgorithms:master
from
samuelfac:cleanup_StringMatchFiniteAutomata
Jun 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5222 +/- ##
============================================
+ Coverage 39.22% 39.46% +0.23%
- Complexity 2401 2416 +15
============================================
Files 517 517
Lines 15522 15522
Branches 2958 2959 +1
============================================
+ Hits 6089 6126 +37
+ Misses 9140 9105 -35
+ Partials 293 291 -2 ☔ View full report in Codecov by Sentry. |
Let's focus on #5221 first. |
6 tasks
vil02
requested changes
Jun 12, 2024
src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Outdated
Show resolved
Hide resolved
samuelfac
commented
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed main
vil02
requested changes
Jun 13, 2024
src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/others/StringMatchFiniteAutomataTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Outdated
Show resolved
Hide resolved
…ta.java Co-authored-by: Piotr Idzik <[email protected]>
…ta.java Co-authored-by: Piotr Idzik <[email protected]>
…ta.java Co-authored-by: Piotr Idzik <[email protected]>
vil02
reviewed
Jun 17, 2024
src/test/java/com/thealgorithms/others/StringMatchFiniteAutomataTest.java
Outdated
Show resolved
Hide resolved
vil02
approved these changes
Jun 17, 2024
StringMatchFiniteAutomata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5164
clang-format -i --style=file path/to/your/file.java