Skip to content

Optimize AbsoluteMax.getMaxValue() for efficiency #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sowndappan5
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.72%. Comparing base (a81fb32) to head (8db2c1f).

Files Patch % Lines
...main/java/com/thealgorithms/maths/AbsoluteMax.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5215      +/-   ##
============================================
- Coverage     38.72%   38.72%   -0.01%     
- Complexity     2383     2384       +1     
============================================
  Files           517      517              
  Lines         15392    15395       +3     
  Branches       2954     2955       +1     
============================================
+ Hits           5961     5962       +1     
  Misses         9144     9144              
- Partials        287      289       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02
Copy link
Member

vil02 commented Jun 8, 2024

You claim that thanks to your change, the code will be faster. Could you please prove that?

@sowndappan5 sowndappan5 closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants