Skip to content

style: include SS_SHOULD_BE_STATIC #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 1, 2024

Continuation of #5122.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 2.22222% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 38.70%. Comparing base (c42b1c9) to head (9d8dd4c).

Files Patch % Lines
...healgorithms/datastructures/trees/RedBlackBST.java 0.00% 44 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5198      +/-   ##
============================================
+ Coverage     38.68%   38.70%   +0.01%     
- Complexity     2383     2384       +1     
============================================
  Files           517      517              
  Lines         15405    15403       -2     
  Branches       2959     2960       +1     
============================================
+ Hits           5960     5961       +1     
+ Misses         9158     9156       -2     
+ Partials        287      286       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 force-pushed the include_SS_SHOULD_BE_STATIC branch from 6c570ba to 9d8dd4c Compare June 1, 2024 20:43
@vil02 vil02 marked this pull request as ready for review June 1, 2024 20:54
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@BamaCharanChhandogi BamaCharanChhandogi merged commit 5e4db7b into TheAlgorithms:master Jun 1, 2024
5 checks passed
@vil02 vil02 deleted the include_SS_SHOULD_BE_STATIC branch June 1, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants