-
Notifications
You must be signed in to change notification settings - Fork 19.9k
style: enabled InnerAssignment
in checkstyle
#5162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5162 +/- ##
=========================================
Coverage 38.26% 38.27%
Complexity 2362 2362
=========================================
Files 516 516
Lines 15304 15322 +18
Branches 2956 2957 +1
=========================================
+ Hits 5856 5864 +8
- Misses 9164 9173 +9
- Partials 284 285 +1 ☔ View full report in Codecov by Sentry. |
src/main/java/com/thealgorithms/dynamicprogramming/KnapsackMemoization.java
Show resolved
Hide resolved
This should fix the clang-format error.
InnerAssignment
in checkstyle
src/main/java/com/thealgorithms/dynamicprogramming/KnapsackMemoization.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/dynamicprogramming/KnapsackMemoization.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I allowed myself to push few commits into your branch, I hope you don't mind.
I will merge it as soon as codecov will allow it... |
No not at all. Thank you for helping me learn and improve! |
Feel free to create PRs witch add missing tests, like #5160. This is the best way to find and fix bugs. |
Related to #5119