Skip to content

style: enabled InnerAssignment in checkstyle #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2024

Conversation

CodaBlurd
Copy link
Contributor

Related to #5119

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 38.27%. Comparing base (f8e62fb) to head (701abc9).

Files Patch % Lines
...ain/java/com/thealgorithms/searches/UnionFind.java 0.00% 3 Missing ⚠️
.../java/com/thealgorithms/ciphers/ProductCipher.java 0.00% 2 Missing ⚠️
...thms/datastructures/dynamicarray/DynamicArray.java 0.00% 2 Missing ⚠️
...lgorithms/datastructures/queues/CircularQueue.java 0.00% 2 Missing ⚠️
...ithms/datastructures/trees/PrintTopViewofTree.java 0.00% 2 Missing ⚠️
...healgorithms/datastructures/trees/RedBlackBST.java 0.00% 2 Missing ⚠️
...amicprogramming/LongestAlternatingSubsequence.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5162   +/-   ##
=========================================
  Coverage     38.26%   38.27%           
  Complexity     2362     2362           
=========================================
  Files           516      516           
  Lines         15304    15322   +18     
  Branches       2956     2957    +1     
=========================================
+ Hits           5856     5864    +8     
- Misses         9164     9173    +9     
- Partials        284      285    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This should fix the clang-format error.
@vil02 vil02 changed the title style: enabled InnerAssignment in checkstyle style: enabled InnerAssignment in checkstyle May 16, 2024
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I allowed myself to push few commits into your branch, I hope you don't mind.

@vil02 vil02 enabled auto-merge (squash) May 16, 2024 15:52
@vil02
Copy link
Member

vil02 commented May 16, 2024

I will merge it as soon as codecov will allow it...

@CodaBlurd
Copy link
Contributor Author

No not at all. Thank you for helping me learn and improve!

@vil02
Copy link
Member

vil02 commented May 16, 2024

Feel free to create PRs witch add missing tests, like #5160. This is the best way to find and fix bugs.

@vil02 vil02 merged commit 0f42e99 into TheAlgorithms:master May 16, 2024
5 checks passed
@CodaBlurd CodaBlurd deleted the enable_InnerAssignment branch May 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants