Skip to content

style: include NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 8, 2024

Continuation of #5126.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 38.16%. Comparing base (d3bb691) to head (4904bde).

Files Patch % Lines
...va/com/thealgorithms/ciphers/a5/CompositeLFSR.java 0.00% 3 Missing ⚠️
...ms/datastructures/graphs/DIJSKSTRAS_ALGORITHM.java 0.00% 2 Missing ⚠️
...m/thealgorithms/datastructures/graphs/PrimMST.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5149   +/-   ##
=========================================
  Coverage     38.16%   38.16%           
  Complexity     2362     2362           
=========================================
  Files           517      517           
  Lines         15350    15350           
  Branches       2965     2965           
=========================================
  Hits           5858     5858           
  Misses         9205     9205           
  Partials        287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 8, 2024 16:59
@vil02 vil02 enabled auto-merge (squash) May 8, 2024 16:59
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks

@vil02 vil02 merged commit d2ddec5 into TheAlgorithms:master May 8, 2024
5 checks passed
@vil02 vil02 deleted the use_assertTrue_and_assertFalse branch May 8, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants