Skip to content

style: enable ConstantName in checkstyle #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

marysiuniq
Copy link
Contributor

Related to #5119.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 44.87179% with 43 lines in your changes missing coverage. Please review.

Project coverage is 37.34%. Comparing base (ede3e46) to head (e16dff7).
Report is 347 commits behind head on master.

Files with missing lines Patch % Lines
...va/com/thealgorithms/backtracking/KnightsTour.java 0.00% 10 Missing ⚠️
.../main/java/com/thealgorithms/others/RabinKarp.java 0.00% 8 Missing ⚠️
.../dynamicprogramming/MatrixChainMultiplication.java 0.00% 7 Missing ⚠️
.../thealgorithms/matrixexponentiation/Fibonacci.java 0.00% 6 Missing ⚠️
...va/com/thealgorithms/datastructures/trees/LCA.java 0.00% 5 Missing ⚠️
...om/thealgorithms/dynamicprogramming/Fibonacci.java 0.00% 4 Missing ⚠️
...in/java/com/thealgorithms/maths/FindKthNumber.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5139      +/-   ##
============================================
- Coverage     37.36%   37.34%   -0.02%     
+ Complexity     2350     2349       -1     
============================================
  Files           517      517              
  Lines         15618    15618              
  Branches       2971     2971              
============================================
- Hits           5836     5833       -3     
- Misses         9495     9496       +1     
- Partials        287      289       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marysiuniq marysiuniq force-pushed the enable_ConstantName branch from 3d98864 to e16dff7 Compare May 2, 2024 16:22
@vil02 vil02 merged commit 1e2d7e9 into TheAlgorithms:master May 2, 2024
5 checks passed
@vil02 vil02 mentioned this pull request May 2, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants