Skip to content

style: enable ModifierOrder in checkstyle #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2024

Conversation

marysiuniq
Copy link
Contributor

@marysiuniq marysiuniq commented May 1, 2024

I enabled ModifierOrder in checkstyle.

Related to #5119.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.33%. Comparing base (fd65892) to head (5a5171a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5132      +/-   ##
============================================
- Coverage     37.35%   37.33%   -0.02%     
+ Complexity     2350     2349       -1     
============================================
  Files           517      517              
  Lines         15622    15622              
  Branches       2971     2971              
============================================
- Hits           5836     5833       -3     
- Misses         9499     9500       +1     
- Partials        287      289       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marysiuniq marysiuniq requested a review from vil02 May 1, 2024 11:01
Maria Paszkiewicz SCC and others added 2 commits May 1, 2024 13:02
@marysiuniq marysiuniq force-pushed the enable_ModifierOrder branch from 7055acd to 5a5171a Compare May 1, 2024 11:02
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vil02 vil02 merged commit 06a284f into TheAlgorithms:master May 1, 2024
5 checks passed
@vil02 vil02 mentioned this pull request May 1, 2024
26 tasks
@marysiuniq marysiuniq deleted the enable_ModifierOrder branch May 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants