Skip to content

fix: handle empty inputs in CircleSort #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 5, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 26, 2024

This PR adds tests for CircleSort and fixes the infinite loop occurring for empty input.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.55%. Comparing base (6bde5d7) to head (9a7a5e5).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5121      +/-   ##
============================================
+ Coverage     37.36%   37.55%   +0.18%     
- Complexity     2350     2364      +14     
============================================
  Files           517      517              
  Lines         15613    15605       -8     
  Branches       2968     2965       -3     
============================================
+ Hits           5834     5860      +26     
+ Misses         9491     9458      -33     
+ Partials        288      287       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review April 26, 2024 06:55
@vil02 vil02 mentioned this pull request Apr 26, 2024
6 tasks
@vil02 vil02 enabled auto-merge (squash) April 27, 2024 07:30
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vil02 vil02 merged commit 5d00889 into TheAlgorithms:master May 5, 2024
5 checks passed
@vil02 vil02 deleted the add_test_for_CircleSort branch May 5, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants