Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
checkstyle
to this project. Thecheckstyle.xml
is derived from sun_checks.xml by commenting out some some of the rules - they are marked byTODO
. I think it might be a good idea to introduce some of them in the future. I will create an issue, where one can discuss which rules should be enabled.The
build.yml
will fail if any warning would be found.At the moment there is some unused import in one of the tests.Fixed in #5113.@siriak what is your opinion?
clang-format -i --style=file path/to/your/file.java