Skip to content

Added tests for FactorialRecursion #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marysiuniq
Copy link
Contributor

Added tests for FactorialRecursion.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@marysiuniq marysiuniq force-pushed the add_tests_for_factorial_recursion branch from b96dc2e to 002de56 Compare April 20, 2024 18:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.24%. Comparing base (05626f7) to head (86bd720).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5109      +/-   ##
============================================
+ Coverage     37.20%   37.24%   +0.04%     
- Complexity     2338     2343       +5     
============================================
  Files           517      517              
  Lines         15637    15630       -7     
  Branches       2979     2975       -4     
============================================
+ Hits           5817     5822       +5     
+ Misses         9532     9521      -11     
+ Partials        288      287       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If you would be looking for ideas for further PRs you can consider merging tests of Factorial.java and FactorialRecursion.java into a single file similarly as you did in your previous PR #5107.

@vil02 vil02 merged commit 8129686 into TheAlgorithms:master Apr 20, 2024
5 checks passed
@marysiuniq marysiuniq deleted the add_tests_for_factorial_recursion branch April 20, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants