-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Implement Parentheses Generator #5096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Parentheses Generator #5096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions (just questions, I want to know your reasons):
- why did you use
List<String>
and not another container? (maybe set), - what do you think about marking methods of
ParenthesesGenerator
asstatic
?
In general the code looks good.
src/test/java/com/thealgorithms/backtracking/ParenthesesGeneratorTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/backtracking/ParenthesesGenerator.java
Outdated
Show resolved
Hide resolved
|
I will change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done!
clang-format -i --style=file path/to/your/file.java