Update QuickSort.java #5089
Update QuickSort.java #5089
Conversation
I've made the following changes: 1.Renamed doSort to quickSort for clarity. 2.Renamed randomPartition to partitionWithRandomPivot. 3.Added inline comments for clarity. 4.Reused existing utility methods from SortUtils. 5.Ensured error handling by checking for edge cases like null arrays. 6.Maintained the core logic of the QuickSort algorithm while optimizing readability and maintainability.
manishraj27
requested review from
yanglbme,
vil02 and
BamaCharanChhandogi
as code owners
| */ | ||
| @Override | ||
| public <T extends Comparable<T>> T[] sort(T[] array) { | ||
| doSort(array, 0, array.length - 1); | ||
| quickSort(array, 0, array.length - 1); |
There was a problem hiding this comment.
Error Handling: You should add a check to handle cases where the array is null or has only one element, returning the array directly in such cases.
| quickSort(array, 0, array.length - 1); | |
| if (array == null || array.length <= 1) { | |
| return array; | |
| } | |
| quickSort(array, 0, array.length - 1); |
|
Random Pivot Selection: In your implementation, the pivot selection logic should be more intuitive and clear. The pivot is always chosen from the rightmost element of the array. |
| * @author Podshivalov Nikita (https://github.com/nikitap492) | ||
| * Implementation of the QuickSort algorithm. | ||
| * | ||
| * @author Manish Raj (https://github.com/manishraj27) | ||
| * @see SortAlgorithm | ||
| */ | ||
| class QuickSort implements SortAlgorithm { | ||
|
|
||
| /** |
There was a problem hiding this comment.
| /** | |
| private static final int RANDOM_BOUND = 1; | |
| /** |
| */ | ||
| private static <T extends Comparable<T>> int randomPartition(T[] array, int left, int right) { | ||
| private static <T extends Comparable<T>> int partitionWithRandomPivot(T[] array, int left, int right) { | ||
| int randomIndex = left + (int) (Math.random() * (right - left + 1)); |
There was a problem hiding this comment.
| int randomIndex = left + (int) (Math.random() * (right - left + 1)); | |
| int randomIndex = left + (int) (Math.random() * (right - left + RANDOM_BOUND)); |
|
Partitioning Logic: Simplified the partitioning logic by using a single loop instead of nested while loops, which makes it easier to understand. What do you think about this suggestion: /**
* Partitions the array around a pivot element.
*
* @param array The array to be partitioned.
* @param left The leftmost index of the subarray.
* @param right The rightmost index of the subarray.
* @return The index of the pivot element after partitioning.
*/
private static <T extends Comparable<T>> int partition(T[] array, int left, int right) {
T pivot = array[right];
int i = left - 1;
for (int j = left; j < right; j++) {
if (array[j].compareTo(pivot) <= 0) {
i++;
swap(array, i, j);
}
}
swap(array, i + 1, right);
return i + 1;
}
} |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
|
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
I've made the following changes:
1.Renamed doSort to quickSort for clarity.
2.Renamed randomPartition to partitionWithRandomPivot. 3.Added inline comments for clarity.
4.Reused existing utility methods from SortUtils.
5.Ensured error handling by checking for edge cases like null arrays. 6.Maintained the core logic of the QuickSort algorithm while optimizing readability and maintainability.
clang-format -i --style=file path/to/your/file.java