Skip to content

feat: remove CalculateMaxOfMin as it is implemented incorrectly #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2024
Merged

feat: remove CalculateMaxOfMin as it is implemented incorrectly #5079

merged 2 commits into from
Mar 22, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Mar 17, 2024

As discussed in #5038 - this PR removes CalculateMaxOfMin.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 enabled auto-merge (squash) March 17, 2024 20:11
@yanglbme yanglbme force-pushed the remove_CalculateMaxOfMin branch from 35c80a8 to 7b8fcc9 Compare March 22, 2024 11:15
@yanglbme yanglbme disabled auto-merge March 22, 2024 11:16
@yanglbme yanglbme merged commit 098f044 into master Mar 22, 2024
@yanglbme yanglbme deleted the remove_CalculateMaxOfMin branch March 22, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme approved these changes

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @yanglbme