Skip to content

Add MinValueTest and remove main from MinValue #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 9, 2023
Merged

Add MinValueTest and remove main from MinValue #4713

merged 14 commits into from
Oct 9, 2023

Conversation

lukasb1b
Copy link
Contributor

@lukasb1b lukasb1b commented Oct 7, 2023

Adding Test to MinValue

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@lukasb1b lukasb1b marked this pull request as ready for review October 7, 2023 17:13
@vil02
Copy link
Member

vil02 commented Oct 8, 2023

@lukasb1b where are the tests?

@lukasb1b
Copy link
Contributor Author

lukasb1b commented Oct 8, 2023

@vil02 sry I forgot to mearch a branch

vil02
vil02 requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the opportunity and update the doc-string.

@vil02 vil02 self-assigned this Oct 8, 2023
@lukasb1b
Copy link
Contributor Author

lukasb1b commented Oct 8, 2023

Sure upadte it. I think you should be able to change the file.

@vil02 vil02 changed the title Min value Test Add MinValueTest and remove main from MinValue Oct 9, 2023
@vil02 vil02 merged commit c6a22de into TheAlgorithms:master Oct 9, 2023
@lukasb1b lukasb1b mentioned this pull request Oct 10, 2023
Merged
6 tasks
@lukasb1b lukasb1b deleted the MinValue branch October 10, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees

@vil02 vil02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasb1b @vil02