Skip to content

[FEATURE] #4486 QuickSort Algo for LinkedList #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Prabhat-Kumar-42
Copy link
Contributor

Description :

  • Added QuickSort Algorithm for Linked List.
  • Provided a detailed documentation in source-code file
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@Prabhat-Kumar-42
Copy link
Contributor Author

Prabhat-Kumar-42 commented Oct 1, 2023

Hey,

I added the QuickSort feature for linked lists. Please review it.

Although I have checked it for various test cases, if any issue arises, please let me know, and I will resolve it as soon as possible.

I request the maintainer(s) to please merge my request using "hacktoberfest-accepted" label.

Thank you! 😊

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add three files, and should that file remove the main method, also added test cases.

@Prabhat-Kumar-42
Copy link
Contributor Author

Prabhat-Kumar-42 commented Oct 1, 2023

Why did you add three files, and should that file remove the main method, also added test cases.

Yes, thank you for notifying me about the extra files. I really appreciate it. These are the files from other PRs I made in this repo.
I accidentally created the new feature branch from the previous working feature branch, instead of the master branch.
I removed the extra files.
Also, the main method is just for test cases, it can be safely removed, but I just left it there in case someone wanted to test the source code.

If there's anything else, please let me know.

Thank You.

@BamaCharanChhandogi
Copy link
Member

Hello, please review the other LinkedList files to understand how to add different test case files. After adding test cases, you should remove the main method, as it is not needed.

Secondly, there is no need to create a LinkedList class. You are importing a package, so you can use it without declaring a node class.

@BamaCharanChhandogi BamaCharanChhandogi self-assigned this Oct 1, 2023
@Prabhat-Kumar-42
Copy link
Contributor Author

Prabhat-Kumar-42 commented Oct 1, 2023

Hello, please review the other LinkedList files to understand how to add different test case files. After adding test cases, you should remove the main method, as it is not needed.

Secondly, there is no need to create a LinkedList class. You are importing a package, so you can use it without declaring a node class.

Got it, Thank you for the review. Currently Working on the issues you mentioned.
Also, can I be assigned to this and my other PR's ?

@Prabhat-Kumar-42
Copy link
Contributor Author

@BamaCharanChhandogi
Please review the code.
Ignore the main method as it will be removed after building the test file.
If everything's alright with it then I will move to the build the test file.
Thank You !!

@Prabhat-Kumar-42
Copy link
Contributor Author

@BamaCharanChhandogi
Just a quick follow-up.
I have resolved the issues about extra-files, main method and added test code as you mentioned.
Please review the progress.
Let me know if something needs to be added.

Thank You !!

@BamaCharanChhandogi
Copy link
Member

Looks good

@Prabhat-Kumar-42
Copy link
Contributor Author

Prabhat-Kumar-42 commented Oct 1, 2023

Looks good

Thank You for the review.
This is if first time contributing to open-source. I hope I am doing alright and thank you for guiding me through this contribution @BamaCharanChhandogi.
If everything with the code seems fine to you, I am looking forward to merging my PR.
I would humbly request the maintainer(s) to please merge my request using the "hacktoberfest-accepted" label.
That would be helpful.
Thank You !!

@BamaCharanChhandogi BamaCharanChhandogi enabled auto-merge (squash) October 1, 2023 15:56
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants