-
Notifications
You must be signed in to change notification settings - Fork 20k
Update Pangram.java using Java Collections #4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A simple separate function isPangramOrNot(String s) has been created which implements the Pangram checking of a string using Java Collection Framework approach.
I request the maintainer(s) to merge my request using "hacktoberfest-accepted" label. |
Co-authored-by: Debasish Biswas <[email protected]>
Looks like you haven't add test for your function. (It is always better to add test you know) BTW thanks for contributing. |
Ok, I will update the method name isPangramUsingSet(String s) and also add some tests for my method. |
Method name updated to - isPangramUsingSet(String s)
Hi, I have updated the function name to isPangramUsingSet(String s) and also added tests for my function. P.S. - I would be grateful if my contribution is accepted and merged using "hacktoberfest-accepted" label. |
Add the test in this barnch. |
Successfully updated the testcases in this same PR branch
Hii, I have updated the test cases in PangramTest.java file in this current PR branch itself. P.S. - Looking forward to having my contribution merged and accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Thanks
A simple separate function isPangramOrNot(String s) has been created which implements the Pangram checking of a string using Java Collection Framework approach.