Added [FEATURE REQUEST] <Recursive Binary Search> #4457 #4469
Conversation
debnath003
commented
Oct 1, 2023
debnath003
commented
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
debnath003
requested review from
yanglbme,
debasishbsws,
vil02 and
BamaCharanChhandogi
as code owners
|
I have given the recursive binary search code in Java and created a PR, could you please merge it? @debasishbsws @BamaCharanChhandogi |
src/main/java/com/thealgorithms/searches/RecursiveBinarySearch.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/searches/RecursiveBinarySearch.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/searches/RecursiveBinarySearch.java
Outdated
Show resolved
Hide resolved
|
I have resolved all the resolved conversations, could you please review it? @debasishbsws |
|
@debasishbsws I have done the required changes and updated the codes, could you please merge my PR? |
|
@debasishbsws could you please review the changes and merge my PR? |
There was a problem hiding this comment.
It is great that you have added the tests for the algo. But the implementation is little bit different from my expectation.
You can refer to the BinarySearch.java for understanding for what I am suggesting.
Your class RecursiveBinarySearch should extend the SearchAlogrithm class and implement the find method, that should call your function.
BTW thanks for your contributions, you are doing great so far.
|
After editing that part, will you merge this PR? Coz everything is okay in that code |
|
I have done what you have told me as follows: my class RecursiveBinarySearch should extend the SearchAlogrithm class and implement the find method, can you please check it @debasishbsws |
