Skip to content

Moved StackPostfixNotation.java from the Others section to the Stack section #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

beradeep
Copy link
Contributor

@beradeep beradeep commented Sep 13, 2023

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Issue

May solve issue #4360

@beradeep beradeep changed the title Moved StackPostfixNotation.java from the Others section to the Stack section #4360 #4360 Moved StackPostfixNotation.java from the Others section to the Stack section Sep 13, 2023
@beradeep beradeep changed the title #4360 Moved StackPostfixNotation.java from the Others section to the Stack section Moved StackPostfixNotation.java from the Others section to the Stack section Sep 13, 2023
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced if an algorithm using a stack should be in the stacks directory. If it should be, then all of the algorithms using any data structure should be in the datastructures directory.

My understanding is that the stacks should contain different implementations of stack.

@beradeep
Copy link
Contributor Author

I think since this one is closely related to the application of stack, and that there are already algorithms like PostfixToInfix.java inside stacks, so moving StackPostNotation.java into stacks makes sense according to me.

@BamaCharanChhandogi
Copy link
Member

I think since this one is closely related to the application of stack, and that there are already algorithms like PostfixToInfix.java inside stacks, so moving StackPostNotation.java into stacks makes sense according to me.

Exactly

@beradeep
Copy link
Contributor Author

So can it be merged?

@siriak
Copy link
Member

siriak commented Sep 14, 2023

Let's create a directory stack in agorithms directory and put stack-related algorithms there. They shouldn't be in datastructures. Besides, please also update file structure of tests to match that of algorithms

@BamaCharanChhandogi
Copy link
Member

@beradeep are you working?

beradeep and others added 3 commits September 18, 2023 09:45
…ithms directory. The stack directory under data-structures now only contains various implementations of the stack data structure.
@beradeep
Copy link
Contributor Author

beradeep commented Sep 18, 2023

@BamaCharanChhandogi @siriak I have tried to incorporate all the requested changes. Is it okay right now?

@beradeep beradeep requested a review from vil02 September 18, 2023 06:53
@vil02 vil02 merged commit 26c2465 into TheAlgorithms:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants