#4358 Fix : Floodfill infinite recursion due to same color #4359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manan-09
requested review from
siriak,
yanglbme,
debasishbsws,
vil02 and
BamaCharanChhandogi
as code owners
Manan-09
changed the title
Manan-09
force-pushed
the
#4358
branch
2 times, most recently
from
dd33754 to
0af9c13
Compare
Manan-09
changed the title
Manan-09
changed the title
vil02
approved these changes
Sep 9, 2023
|
Thanks @vil02 , |
|
@Manan-09 this was my first merge as a maintainer of this repository! Enjoy further contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4358
Fixed case when both newColor and oldColor is passed as same integer causing infinite recursion by adding extra base condition.
Also added testcase for same and after that ran all testcase, which resulted as all passed.