Skip to content

tests: add tests for GenericRoot #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2023
Merged

tests: add tests for GenericRoot #4276

merged 5 commits into from
Aug 3, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jul 31, 2023

This PR:

  • adds tests for the class GenericRoot,
  • does some refactoring if it.

I do not know about the general policy here: should I use the existing methods from SumOfDigits?

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

siriak
siriak approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit ee23b6c into TheAlgorithms:master Aug 3, 2023
@vil02 vil02 deleted the add_tests_of_GenericRoot branch August 3, 2023 20:24
@vil02 vil02 mentioned this pull request Jun 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@albina-astr albina-astr Awaiting requested review from albina-astr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @siriak