fix: handle incorrect inputs in StackPostfixNotation
#4261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
changed the title
StackPostfixNotationTestStackPostfixNotationTest.postfixEvaluate
vil02
changed the title
StackPostfixNotationTest.postfixEvaluateStackPostfixNotationTest
vil02
changed the title
StackPostfixNotationTestStackPostfixNotation
vil02
requested review from
siriak,
yanglbme,
debasishbsws and
albina-astr
as code owners
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
StackPostfixNotation.postfixEvaluate:""),"3 3 3".This PR:
I did not update the doc string, since I believe this class needs some refactoring anyway (e.g. the method
postfixEvaluateis way too long). I am also concerned with the current formatting: this line seems way too long. In my opinion both of these are out of scope for this PR.