Skip to content

Add all combination #4156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add all combination #4156

wants to merge 3 commits into from

Conversation

BamaCharanChhandogi
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi commented Apr 17, 2023 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

I added All-Combination Algorithm using Backtracking.

@BamaCharanChhandogi BamaCharanChhandogi mentioned this pull request Apr 17, 2023
Closed
@siriak
Copy link
Member

siriak commented Apr 17, 2023

I think it's already implemented here https://github.com/TheAlgorithms/Java/blob/1dc388653a3895fe51f464c5b0f140bb88216dc8/src/main/java/com/thealgorithms/maths/Combinations.java

@siriak siriak closed this Apr 17, 2023
@BamaCharanChhandogi
Copy link
Member Author

I think it's different.
thanks.

@siriak
Copy link
Member

siriak commented Apr 19, 2023

I added wrong link, should have added this one instead https://github.com/TheAlgorithms/Java/blob/1dc388653a3895fe51f464c5b0f140bb88216dc8/src/main/java/com/thealgorithms/backtracking/Combination.java

@BamaCharanChhandogi
Copy link
Member Author

Yeah, This is right but my code is best for beginner to Intermediate.

@BamaCharanChhandogi BamaCharanChhandogi deleted the add-allCombination branch May 27, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak Awaiting requested review from siriak siriak is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BamaCharanChhandogi @siriak